Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ID-83]Fix Legacy event import #84

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

stefanvit
Copy link
Collaborator

Description

Fix Legacy event import

**Resolves #83

Review Time Estimate

  • Immediately
  • Within a week
  • When possible

Type of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@stefanvit stefanvit requested a review from petyos April 22, 2024 06:28
@stefanvit stefanvit requested a review from clint156 as a code owner April 22, 2024 06:28
@stefanvit stefanvit linked an issue Apr 22, 2024 that may be closed by this pull request
Copy link
Collaborator

@petyos petyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanvit stefanvit merged commit 964eaf4 into develop Apr 22, 2024
2 checks passed
@stefanvit stefanvit deleted the 83-fix-legacy-event-import branch April 22, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Legacy event import
2 participants