Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ID-92]Webtools images fixes #93

Merged
merged 3 commits into from
May 7, 2024
Merged

[ID-92]Webtools images fixes #93

merged 3 commits into from
May 7, 2024

Conversation

stefanvit
Copy link
Collaborator

Description

  1. It seems you call the Webtools image API two times. It should work with only one call.
  2. When you download an image you store it on the file system. Please try without saving it but directly work with the bytes in the memory.

**Resolves #92

Review Time Estimate

  • Immediately
  • Within a week
  • When possible

Type of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@stefanvit stefanvit requested a review from petyos May 7, 2024 03:11
@stefanvit stefanvit requested a review from clint156 as a code owner May 7, 2024 03:11
@stefanvit stefanvit linked an issue May 7, 2024 that may be closed by this pull request
@stefanvit
Copy link
Collaborator Author

  1. It seems you call the Webtools image API two times. It should work with only one call.
    I don't see where i call it two times.
  2. When you download an image you store it on the file system. Please try without saving it but directly work with the bytes in the memory.
    i think its ok now, but if you please take a look and give it a try.
    Thanks

@petyos petyos merged commit cc4433e into develop May 7, 2024
2 checks passed
@petyos petyos deleted the 92-webtools-images-fixes branch May 7, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webtools images fixes
2 participants