Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ID-110]Fix API docs #119

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

[ID-110]Fix API docs #119

wants to merge 27 commits into from

Conversation

stefanvit
Copy link
Collaborator

Description

Fixing the documentations.
I think now everything is ok. But take a look when you have a chance.

**Resolves #110

Review Time Estimate

  • Immediately
  • Within a week
  • When possible

Type of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Stefan Vitanov and others added 20 commits November 21, 2022 14:10
@stefanvit stefanvit requested a review from shurwit December 11, 2022 13:40
@stefanvit stefanvit requested a review from mdryankov as a code owner December 11, 2022 13:40
petyos
petyos requested changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@petyos petyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed details on a call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petyos petyos petyos requested changes

@shurwit shurwit Awaiting requested review from shurwit

@mdryankov mdryankov Awaiting requested review from mdryankov mdryankov is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Fix API docs
2 participants
@stefanvit @petyos