Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make catalog pages more human readable format #916

Conversation

ywkim312
Copy link
Collaborator

@ywkim312 ywkim312 commented Apr 28, 2022

Description

Please provide a summary of the pull request and the issue it fixes. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.

Fixes #908 #909 #914 #915

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ywkim312 ywkim312 marked this pull request as ready for review May 2, 2022 20:03
@ywkim312 ywkim312 requested review from minump and sandeep-ps as code owners May 2, 2022 20:03
Copy link
Collaborator

@minump minump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all 4 changes. Approved.

@sandeep-ps
Copy link
Collaborator

Removing PR from GitHub project.

@sandeep-ps sandeep-ps removed the enhancement New feature or request label May 11, 2022
@sandeep-ps
Copy link
Collaborator

Hi, @ywkim312, Creating contributions seems to be working fine, but editing the Contrbution results in the person/organization details getting removed. Please look into this when you get a chance. Thanks.

@sandeep-ps
Copy link
Collaborator

This is the error I'm seeing in the logs.

    return self.view_functions[rule.endpoint](**req.view_args)
  File "rokwire-building-blocks-api/contributions/catalog/controllers/auth.py", line 25, in wrapped_view
    return view(**kwargs)
  File "rokwire-building-blocks-api/contributions/catalog/controllers/contribute.py", line 227, in contribution_edit
    if username in the_json_res["contributionAdmins"]:
KeyError: 'contributionAdmins'

@ywkim312
Copy link
Collaborator Author

This is the error I'm seeing in the logs.

    return self.view_functions[rule.endpoint](**req.view_args)
  File "rokwire-building-blocks-api/contributions/catalog/controllers/auth.py", line 25, in wrapped_view
    return view(**kwargs)
  File "rokwire-building-blocks-api/contributions/catalog/controllers/contribute.py", line 227, in contribution_edit
    if username in the_json_res["contributionAdmins"]:
KeyError: 'contributionAdmins'

Hmm this is an error that usually comes out when I tried to edit configuration but the actual contribution get removed from the db. For example, I created the new contribution in the browser, but removed the contribution record from the db but browser still has the contribution records on the screen, then I click the edit contribution button....

@ywkim312
Copy link
Collaborator Author

Hi, @ywkim312, Creating contributions seems to be working fine, but editing the Contrbution results in the person/organization details getting removed. Please look into this when you get a chance. Thanks.

hmm I can't replicate it.

@sandeep-ps
Copy link
Collaborator

After little more debugging with Yongwook, we think the above error is not related to this PR. The issue has been added to #922

@sandeep-ps sandeep-ps merged commit e59e5f8 into develop May 12, 2022
@sandeep-ps sandeep-ps deleted the 909--Create-a-html-instead-of-using-the-json-value-in-catalog branch May 12, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment