Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#32] Delete survey responses for deleted tenant app memberships #33

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

roberlander2
Copy link
Contributor

Description

This PR introduces the use of the coreservice package of the auth library to automate retrieval of deleted account app membership data from the Core BB. Survey responses associated with these deleted memberships are deleted according to the RetainResponses field of the underlying survey as well as additional context data provided by the user on which survey responses to retain.

Depends on rokwire/core-auth-library-go#98
Resolves #32

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

…vey responses, add RetainResponses to Survey model, upgrade go version and dependencies [#32]
@roberlander2 roberlander2 self-assigned this Mar 15, 2024
@roberlander2 roberlander2 requested a review from shurwit as a code owner March 15, 2024 15:36
@petyos
Copy link
Collaborator

petyos commented Apr 9, 2024

Hi @roberlander2 , it seems there is an issue with the build of the PR.

@roberlander2
Copy link
Contributor Author

Hi @roberlander2 , it seems there is an issue with the build of the PR.

Hi @petyos, yes, this PR will need to wait for another release of the auth library to be made including the changes in rokwire/core-auth-library-go#98.

@stefanvit
Copy link
Collaborator

Hi @roberlander2, i am working on this now. Could you please tell me , when you have time, what RetainResponses bool json:"retain_responses" bson:"retain_responses" does and what is its purpose and also about ignoreMissingError bool.
Thank you very much!

@roberlander2
Copy link
Contributor Author

Hi @roberlander2, i am working on this now. Could you please tell me , when you have time, what RetainResponses bool json:"retain_responses" bson:"retain_responses" does and what is its purpose and also about ignoreMissingError bool. Thank you very much!

Hi @stefanvit, RetainResponses is meant to indicate whether the service should delete survey responses for that survey when a user deletes his membership. The ignoreMissingError bool is meant to stop the service from throwing unnecessary errors if it tries to delete survey responses for a deleted user membership that does not have any associated survey responses.

Thanks! Please let me know if anything is still unclear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Delete survey responses for deleted tenant app memberships
3 participants