Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ID-34]Remove user data #35

Merged
merged 13 commits into from
Jul 11, 2024
Merged

[ID-34]Remove user data #35

merged 13 commits into from
Jul 11, 2024

Conversation

stefanvit
Copy link
Collaborator

Description

Remove user data
**Resolves #34

Review Time Estimate

  • Immediately
  • Within a week
  • When possible

Type of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@stefanvit stefanvit requested a review from petyos July 6, 2024 14:42
@stefanvit stefanvit requested a review from shurwit as a code owner July 6, 2024 14:42
@stefanvit stefanvit linked an issue Jul 6, 2024 that may be closed by this pull request
[FEATURE] Remove user data #34
Closed
@stefanvit
Copy link
Collaborator Author

Hi @petyos, the reason for the error on the build is that i couldn't generate the mocks for some reason. I use the way that is written in the convensions but it hits the wall every time. Could you please help me? Thank you.

@petyos
Copy link
Collaborator

petyos commented Jul 9, 2024

Hi @stefanvit ,

Please try:
cd core
mockery --name=Storage

petyos
petyos requested changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@petyos petyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not mock all files but only Storage as it is now. This is out of the issue scope.

core/interfaces.go Outdated Show resolved Hide resolved
@stefanvit stefanvit requested a review from petyos July 10, 2024 07:21
petyos
petyos requested changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@petyos petyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look into the feedback comments.

core/application.go Show resolved Hide resolved
core/application_test.go Outdated Show resolved Hide resolved
core/model/surveys.go Outdated Show resolved Hide resolved
driven/storage/adapter.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@stefanvit stefanvit requested a review from petyos July 11, 2024 09:34
petyos
petyos reviewed Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@petyos petyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments.

driven/storage/adapter.go Show resolved Hide resolved
driven/storage/adapter.go Show resolved Hide resolved
@stefanvit stefanvit merged commit b5b4c1a into develop Jul 11, 2024
2 checks passed
@stefanvit stefanvit deleted the 34-feature-remove-user-data branch July 11, 2024 14:24
roberlander2 added a commit to rokmetro/surveys-building-block-fork that referenced this pull request Jul 26, 2024
@roberlander2 @stefanvit
Update develop (#2)
0d28682 
* [ID-34]Remove user data (rokwire#35)

* set the core adapter in the application and set the delete logic file

* in progress

* set delete survey responses and delete surveys

* set the Changelog.md

* fix lint issues

* mocks

* remove unused code

* Revert "mocks"

This reverts commit 845dd92.

* storage mocks

* after go mod tidy

* mocks

* resolve comments

* resolve comments

---------

Co-authored-by: Stefan Vitanov <[email protected]>

* update the version to 1.4.0

* update the dockerfile

* [ID-38]Start/end date (rokwire#41)

* set the Changelog.md

* set start_date and end_date fields if they are missing

* set the docs

* remove unused code

* make start_date and end_date int in the model

* set start_date and end date

* add start_date and end_date to updateSurvey

* set the POST /surveys

* fix PUT admin/surveys

* time filter for survey

* set request as not required

* add filter for start_date and end_date filter for GET surveys

* mockery

* set request body as nullable

* fix filter

* fix app and org id filter

---------

Co-authored-by: Stefan Vitanov <[email protected]>

* update the version to 1.5.0

* [ID-43]Fix "start_date" and "end_date" (rokwire#44)

* set the response to start_date and end_date to be UNIX timestamp

* set the Changelog.md

* set start_date as nullable

---------

Co-authored-by: Stefan Vitanov <[email protected]>

* [ID-39]Add extras field to survey data (rokwire#45)

* set the Changelog.md

* add "extras" to the SurveyData doc

* add "extras" to the model and set it as nullable

---------

Co-authored-by: Stefan Vitanov <[email protected]>

* [ID-37]Public flag (rokwire#46)

* add public flag to the docs

* add public to the model and the conversion

* set the public field in the update filter and in the update conversion

* add public to the query

* fix

* set public

* add response to the admin get surveys API

* set the mocks

---------

Co-authored-by: Stefan Vitanov <[email protected]>

* [ID-40]Archived flag (rokwire#47)

* set the Changelog.md

* fix the Changelog.md

* set the docs

* add archived in progress

* set archived to the update filter

* add archived to the storage filter

* set the mocks

---------

Co-authored-by: Stefan Vitanov <[email protected]>

* update version to 1.6.0

* [ID-49]Add Estimated_completion_time (rokwire#50)

* set the Changelog.md

* set the docs

* add to the model

* fix var name in the model

* set estimated_completion_time for create survey

* set estimated_completion_time to the update

---------

Co-authored-by: Stefan Vitanov <[email protected]>

* update version to 1.7.0

* [ID-52]Fix "start_date" and "end_date" timestamp, "archived", "public" and set "complete" in the result (rokwire#53)

* set the Changelog.md

* fix the docs

* remove unused code

* Revert "remove unused code"

This reverts commit eaa904c.

* in progress

* fix update survey

* fix time filter for Get surveys

* archived fix

* fix the archived in admin API

* fix public

* set complete into the response

* fix the Changelog

* set the mocks

* fix

* fix the Changelog

---------

Co-authored-by: Stefan Vitanov <[email protected]>

* update version to 1.8.0

* [ID-55]Fix "public" and "archived" (rokwire#56)

* set the Changelog.md

* fix "public" and "archived" filter and query

* mocks

---------

Co-authored-by: Stefan Vitanov <[email protected]>

* update version to 1.8.1

* [ID-58]Fix Get /surveys (rokwire#59)

* fix the limit and remove claims.Subject

* set the Changelog.md

---------

Co-authored-by: Stefan Vitanov <[email protected]>

* update version to 1.8.2

* [ID-61]Add "complete" field to show if the survey is completed (rokwire#62)

* in progress

* fix conversion

* fix conversion and set the docs

* add completed

* add the Changelog.md

* mocks

---------

Co-authored-by: Stefan Vitanov <[email protected]>

* update version to1.9.0

---------

Co-authored-by: stefanvitanov <[email protected]>
Co-authored-by: Stefan Vitanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petyos petyos petyos requested changes

@shurwit shurwit Awaiting requested review from shurwit shurwit is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Remove user data
2 participants
@stefanvit @petyos