Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ID-75] Fix GET surveys time filtering #76

Merged
merged 6 commits into from
Aug 21, 2024

Conversation

stefanvit
Copy link
Collaborator

Description

This PR fixes an issue where loading surveys by a time filter did not work because the filter params were being read from the request body instead of query params. It also updates the MongoDB query to account for null values for start_date and end_date.

**Resolves #75

Type of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@stefanvit stefanvit requested a review from shurwit as a code owner August 21, 2024 11:10
@stefanvit stefanvit linked an issue Aug 21, 2024 that may be closed by this pull request
@stefanvit stefanvit merged commit d167069 into develop Aug 21, 2024
2 checks passed
@stefanvit stefanvit deleted the 75-bug-fix-get-surveys-time-filtering branch August 21, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix GET surveys time filtering
1 participant