Option to enable scoped block for DelayedJob plugin #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enabled, this adds job data to any Rollbar reporting that happens within the job, and prevents changes to the scope from polluting the global scope for other jobs.
waltjones
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds a new configuration option to run DelayedJob invocations in a scoped block. When enabled, this adds job data to any Rollbar reporting that happens within the job, and prevents changes to the scope (like calling
scope!within a job) from polluting the global scope for other jobs.I noticed that the Sidekiq plugin had an option for this (#1038) so I followed that format.
Type of change
Related issues
.scopedblock in sidekiq plugin? #1036Checklists
Development
Code review