Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLintify the library and its examples, enable linting in CI #112

Merged
merged 5 commits into from
Feb 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,15 @@ jobs:

strategy:
matrix:
node: [14, 16, 18, 20]
include:
- node: 14
npm: 8
- node: 16
npm: 8
- node: 18
npm: 9
- node: 20
npm: 10

steps:
- name: Checkout
Expand All @@ -25,7 +33,10 @@ jobs:
with:
node-version: ${{ matrix.node }}

- name: Cache
- name: Update npm
run: npm install -g npm@^${{ matrix.npm }}

- name: Set up cache
uses: actions/cache@v4
with:
path: ~/.npm
Expand All @@ -49,9 +60,18 @@ jobs:
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
prettier: true
eslint: false
eslint: true
eslint_args: '--max-warnings 0'
eslint_extensions: js,jsx,ts,tsx

- name: Build library
run: npm run build
- name: Build examples/create-react-app
run: cd examples/create-react-app && npm run build
- name: Build examples/nextjs
run: cd examples/nextjs && npm run build
- name: Build examples/typescript
run: cd examples/typescript && npm run build
mudetroit marked this conversation as resolved.
Show resolved Hide resolved

- name: Test
run: npm run test
23 changes: 17 additions & 6 deletions examples/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
/**
* @file examples/index.js
* @fileoverview This is a repertoire of snippets exploring Rollbar's usage.
*/

/* eslint-disable no-unused-vars, react/jsx-no-undef, react/prop-types */

import React, { useEffect, useState } from 'react';
import Rollbar from 'rollbar';
import { Router, Switch, Route } from 'react-router-dom';
Expand Down Expand Up @@ -33,11 +40,11 @@ const rollbarConfig = {
environment: 'production',
};

const rollbar = new Client('POST_CLIENT_ITEM_ACCESS_TOKEN');
const rollbar_client = new Client('POST_CLIENT_ITEM_ACCESS_TOKEN');

const ROUTE_PARAMS_RE = /\/\d+/g;

const historyListener = historyContext(rollbar, {
const historyListener = historyContext(rollbar_client, {
// optional: default uses location.pathname
formatter: (location, action) =>
location.pathname.replace(ROUTE_PARAMS_RE, ''),
Expand Down Expand Up @@ -96,14 +103,15 @@ function Contacts(props) {
);
}

/* eslint-disable react-hooks/exhaustive-deps, no-undef */

function Home() {
const [currentUser, setCurrentUser] = useState();

useRollbarPerson(currentUser);

useEffect(async () => {
const user = await Auth.getCurrentUser();
if (user) {
useRollbarPerson(user);
}
setCurrentUser(user);
});

Expand Down Expand Up @@ -132,14 +140,16 @@ function ContactDetails({ contactId }) {
return <div>…</div>;
}

/* eslint-enable react-hooks/exhaustive-deps, no-undef */

function App(props) {
return (
<Provider rollbar={rollbar}>
<Router></Router>
<RollbarContext name="">
<ErrorBoundary fallbackUI={ErrorDisplay}>
<div>
<h1>I'm Here</h1>
<h1>I&apos;m Here</h1>
<MyInput>
<ErrorBoundary
level
Expand Down Expand Up @@ -173,6 +183,7 @@ function MyInput(props) {

useEffect(() => {
try {
throw new Error('no data to fetch');
} catch (err) {
rollbar.error('error fetching data', err);
}
Expand Down
1 change: 0 additions & 1 deletion examples/nextjs/babel.config.js

This file was deleted.

2 changes: 1 addition & 1 deletion examples/nextjs/eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
module.exports = {
root: true,
extends: 'next/core-web-vitals',
ignorePatterns: ['node_modules'],
ignorePatterns: ['node_modules', '.next'],
};
Loading
Loading