-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tiasync: add support for vote extensions #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13
This PR adds support for chains that have vote extensions enabled. Tiablob/tiasync does not require the extended commit since a fullnode syncing from Celestia will not enter consensus and require this data. However, there are areas that Cometbft expects and verifies (to varying degrees) these extended commits.
If vote extensions are enabled for a respective height, Cometbft's blocksync ensures a well-formed extended commit is delivered. Since it does not perform signature verification, tiasync will deliver a well-formed extended commit with valid commit data, but mock extended signatures.
On a fullnode restart when vote extensions are enabled for the last block height, Cometbft also verifies the extended commit signatures for that block. A tiasync prerun method has been added to get the extended commit via p2p blocksync in order to allow Cometbft to start up successfully.
These solutions allows a chain with vote extensions enabled to not publish extended commits to Celestia, greatly saving costs for networks with large validator sets and/or large vote extension data.
Other enhancements/fixes: