Update async-race lint rules #1830
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaNb4
reviewed
Aug 17, 2025
| - **Modular Architecture**: Clear separation of concerns between API interaction, UI rendering, and state management. | ||
| - **SPA Implementation**: All content must be generated using TypeScript with strict type checking. | ||
| - **Code Quality**: Adherence to Airbnb's ESLint configuration, with functions limited to 40 lines and avoidance of magic numbers/strings. The `tsconfig.json` must be configured to enforce strict typing principles. | ||
| - **Code Quality**: Adherence to ESLint configuration based on recommended rules for TypeScript and React (`eslint:recommended`, `plugin:@typescript-eslint/recommended`, `plugin:react/recommended`, `plugin:react-hooks/recommended`). Avoid magic numbers and magic strings. The `tsconfig.json` must be configured to enforce strict typing principles (`strict: true`, `noImplicitAny: true`). |
There was a problem hiding this comment.
It only includes React-specific rules, but Angular is also an allowed framework
Comment on lines
+190
to
+193
| - `eslint:recommended` | ||
| - `plugin:@typescript-eslint/recommended` | ||
| - `plugin:react/recommended` | ||
| - `plugin:react-hooks/recommended` |
There was a problem hiding this comment.
To me, the listed rule format looks like a deprecated one. ESLint 9 now uses a new "flat config" system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title of Pull Request
Update ESLint configuration
🤔 This is a ...
Description
Replaced the outdated Airbnb ESLint configuration with a modern, conflict-free setup based on recommended rulesets:
eslint:recommended
plugin:@typescript-eslint/recommended
plugin:react/recommended
plugin:react-hooks/recommended
Updated ESLint requirement in the task description to prevent conflicts with React 18+ and TypeScript 5+, while still enforcing strict type checking (strict: true, noImplicitAny: true).
Removed the strict limit of 40 lines per function from the Code Quality section.
Clarified the code quality requirement to focus on avoiding magic numbers/strings and maintaining strong TypeScript typing.
Reason for change
The original Airbnb style guide caused compatibility issues with the latest versions of React and TypeScript, creating unnecessary friction for students. The new configuration keeps linting strict and modern but avoids outdated or conflicting rules.
Checklist