Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esm-shim): missing exports in types #1670

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

huozhi
Copy link
Contributor

@huozhi huozhi commented Feb 2, 2024

Rollup Plugin Name: esm-shim

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

There's a provideCJSSyntax method exported from es-shim plugin but it's not typed, adding the method type to esm-shim plugin's type file

@huozhi huozhi requested a review from tada5hi as a code owner February 2, 2024 17:50
@huozhi huozhi changed the title types: fix missing export type for esm-shim fix: fix missing export type for esm-shim Feb 2, 2024
@shellscape shellscape changed the title fix: fix missing export type for esm-shim fix(esm-shim): missing exports in types Jun 5, 2024
@shellscape
Copy link
Collaborator

thanks!

@shellscape shellscape merged commit b778ba0 into rollup:master Jun 5, 2024
19 of 20 checks passed
@huozhi huozhi deleted the types/fix-es-shim-type branch June 5, 2024 19:56
younggglcy pushed a commit to younggglcy/plugins that referenced this pull request Jun 6, 2024
types: fix missing export type for esm-shim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants