chore(commonjs): switch to fdir for fewer dependencies #1741
+51
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
added
🔌 plugin-commonjs
dependencies
benmccann
changed the title
This was referenced Jun 27, 2024
kytta
suggested changes
Aug 15, 2024
There was a problem hiding this comment.
Hey there! Please note that I am not a Rollup contributor, and I don't have write access to this repository. Nevertheless, I am interested in this PR being merged, so I voluntarily reviewed it.
As stated in the comments, I can imagine the sudden PNPM version switch to be a problem for the maintainers. As such, I advise you to use an older PNPM version, so that this PR focuses explicitly on the glob -> fdir transition 😄
|
Okay, I'm embarrassed that I haven't read the PR description properly 🤦🏻♂️ I didn't realise this includes a different PR which would update PNPM to v9 ... Ignore that part of my review, then :D |
BREAKING CHANGES: directories listed in dynamicRequireTargets now require a trailing slash
# Conflicts: # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
@rollup/plugin-commonjsThis PR contains:
Are tests included?
Breaking Changes?
Description
Note that this incorporates #1740
globpulls in 27 dependencies: https://npmgraph.js.org/?q=globfdirpulls in none: https://npmgraph.js.org/?q=fdir