fix(dsv): strip bom from csv/tsv files if necessary #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
@CrazyOrr looks like there's a conflict with pnpm-lock.yaml after a recent merge. please run pnpm i in the repo root directory and we'll be good to merge pending tests running in CI.
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
dsvThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
Excel saves UTF-8 CSV files with a BOM. When such files are parsed, the key corresponding to the first column has
0xFEFFas its first character, which leads tokeyNamebecame"keyName"(double-quoted).As this reply suggest, we should use strip-bom to remove the BOM if necessary.