Promote source_regions field in google_compute_healthcheck to ga (Goo…

…gleCloudPlatform#11374)
romanini-ciandt · Aug 6, 2024 · 9ec8aa0 · 9ec8aa0
1 parent 61e38a4
commit 9ec8aa0
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 9 deletions.
diff --git a/mmv1/products/compute/HealthCheck.yaml b/mmv1/products/compute/HealthCheck.yaml
@@ -175,7 +175,6 @@ properties:
     item_type: Api::Type::String
     min_size: 3
     max_size: 3
-    min_version: beta
     description: |
       The list of cloud regions from which health checks are performed. If
       any regions are specified, then exactly 3 regions should be specified.

diff --git a/mmv1/templates/terraform/examples/compute_health_check_http_source_regions.tf.erb b/mmv1/templates/terraform/examples/compute_health_check_http_source_regions.tf.erb
@@ -1,5 +1,4 @@
 resource "google_compute_health_check" "<%= ctx[:primary_resource_id] %>" {
-  provider = "google-beta"
   name = "<%= ctx[:vars]['health_check_name'] %>"
   check_interval_sec = 30
 

diff --git a/mmv1/templates/terraform/examples/compute_health_check_https_source_regions.tf.erb b/mmv1/templates/terraform/examples/compute_health_check_https_source_regions.tf.erb
@@ -1,5 +1,4 @@
 resource "google_compute_health_check" "<%= ctx[:primary_resource_id] %>" {
-  provider = "google-beta"
   name = "<%= ctx[:vars]['health_check_name'] %>"
   check_interval_sec = 30
 

diff --git a/mmv1/templates/terraform/examples/compute_health_check_tcp_source_regions.tf.erb b/mmv1/templates/terraform/examples/compute_health_check_tcp_source_regions.tf.erb
@@ -1,5 +1,4 @@
 resource "google_compute_health_check" "<%= ctx[:primary_resource_id] %>" {
-  provider = "google-beta"
   name = "<%= ctx[:vars]['health_check_name'] %>"
   check_interval_sec = 30
 

diff --git a/mmv1/third_party/terraform/services/compute/resource_compute_health_check_test.go.erb b/mmv1/third_party/terraform/services/compute/resource_compute_health_check_test.go.erb
@@ -384,7 +384,6 @@ resource "google_compute_health_check" "foobar" {
 }
 <% end -%>
 
-<% unless version == 'ga' -%>
 
 func TestAccComputeHealthCheck_srcRegions_update(t *testing.T) {
 	t.Parallel()
@@ -393,7 +392,7 @@ func TestAccComputeHealthCheck_srcRegions_update(t *testing.T) {
 
 	acctest.VcrTest(t, resource.TestCase{
 		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
-		ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
 		CheckDestroy:             testAccCheckComputeHealthCheckDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
@@ -420,7 +419,6 @@ func TestAccComputeHealthCheck_srcRegions_update(t *testing.T) {
 func testAccComputeHealthCheck_srcRegions(hckName string) string {
 	return fmt.Sprintf(`
 resource "google_compute_health_check" "src_region" {
-  provider            = "google-beta"
   name                = "%s"
   description         = "Resource created for Terraform acceptance testing"
   check_interval_sec  = 30
@@ -435,7 +433,6 @@ resource "google_compute_health_check" "src_region" {
 func testAccComputeHealthCheck_srcRegions_update(hckName string) string {
 	return fmt.Sprintf(`
 resource "google_compute_health_check" "src_region" {
-  provider            = "google-beta"
   name                = "%s"
   description         = "Resource updated for Terraform acceptance testing"
   check_interval_sec  = 30
@@ -447,4 +444,3 @@ resource "google_compute_health_check" "src_region" {
 `, hckName)
 }
 
-<% end -%>