Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/UI layout update #48

Closed
wants to merge 7 commits into from

Conversation

dhvcc
Copy link

@dhvcc dhvcc commented May 5, 2022

Hi, this is a fix/enhancment of #29

My changes are:

  • Media queries
  • Painted repl input so it's noticeable
  • Moved toolbar to navbar to save space

A screenshot of 1920x937 inner height window

image

hjyssg and others added 3 commits May 6, 2022 02:52
1. resize_console removed
2. use css
Fix layout issues
Add media queries to have a bit more adaptive UI
Paint repl input so it's noticeable
Move toolbar to navbar to save space
@romanvm
Copy link
Owner

romanvm commented May 8, 2022

Thank you for your contribution. I'll check the PR and update accordingly.

@romanvm
Copy link
Owner

romanvm commented May 8, 2022

Movind the toolbar to the navbar area is a sound idea but media queries don't do a good job of dynamically adjusting the UI while the browser window is being resized. I'll post videos later if needed.

@dhvcc
Copy link
Author

dhvcc commented May 9, 2022

@romanvm I agree that media queries are not the best way of dealing with this stuff. I just added them for a couple of most used cases. I'm ok with removing them

@dhvcc
Copy link
Author

dhvcc commented Jul 15, 2022

Hey, any updates on your decision? Thanks!

@romanvm
Copy link
Owner

romanvm commented Jul 21, 2022

Sorry, I had no time to re-test this one because of the real life stuff. I'll try to do this as soon as I can.

@dhvcc
Copy link
Author

dhvcc commented Jul 21, 2022

No worries mate, just wanted to check this out is not abandoned. This is not urgent, take care and be safe

@romanvm
Copy link
Owner

romanvm commented Aug 23, 2022

I've finally found some time to work on this project. Could you merge the current master into this and resolve possible conflicts?

@dhvcc
Copy link
Author

dhvcc commented Aug 24, 2022

Hi @romanvm 👋
I've updated the PR

@dhvcc
Copy link
Author

dhvcc commented Aug 24, 2022

Seems like there's an issue with builds on master

@romanvm
Copy link
Owner

romanvm commented Aug 26, 2022

I have fixed GH pipelines on master. Please merge again.

@dhvcc
Copy link
Author

dhvcc commented Aug 29, 2022

Not sure if you've seen it, but I pushed new commits, you can start a workflow, @romanvm 👍

@romanvm
Copy link
Owner

romanvm commented Sep 2, 2022

I've tested your PR again. The idea to move the button bar to the top is a good one. But media queries do terrible job of adjusting the debugger UI to the browser's viewport compared to my initial solution. So I'm afraid I cannot accept this PR as it is now. I see 2 options:

a) you leave only the part about the button bar and restore the initial method of resizing the debugger UI;

b) you improve your resizing method (if it's possible).

I admit that my frontend skills are limited and my solution for auto-resizing the debugger UI may not be an optimal one but it does the job.

@dhvcc
Copy link
Author

dhvcc commented Sep 16, 2022

@romanvm Hi, I agree that media queries are terrible, guess I just wanted to do a quick hack. Let me see if I can come up with something better than this.

@dhvcc
Copy link
Author

dhvcc commented Sep 16, 2022

@romanvm quickly hacked a new layout using css grid, heres the showcase. It may still not work idealy on really smal screens where title wraps into 2 lines. This is not the issue of this PR, but of the the way it's coded. I might revisit this and fix this one also. Don't close this PR so I can push here. But yeah, may be give this update a review and some feedback
image

@dhvcc
Copy link
Author

dhvcc commented Oct 20, 2022

@romanvm had to use this lib again so just bumping this issue in case you have time in near future, no rush

@romanvm
Copy link
Owner

romanvm commented Oct 21, 2022

Thanks. I'll check it as soon as I can considering all the circumstances.

@dhvcc
Copy link
Author

dhvcc commented Feb 24, 2024

Hi, revisiting this stale PR. Do I need to sync the new branch to be reviewed?

@romanvm
Copy link
Owner

romanvm commented Feb 28, 2024

Hi. No need to do anything at the moment. I was busy with my life matters for quite a while but hopefully I will be able to address pending PRs soon.

@dhvcc
Copy link
Author

dhvcc commented Feb 29, 2024

Hi. No need to do anything at the moment. I was busy with my life matters for quite a while but hopefully I will be able to address pending PRs soon.

Sure, no pressure, be safe and well, was just wondering around my PRs

@romanvm
Copy link
Owner

romanvm commented Mar 1, 2024

Now the UI is totally broken: it's bigger than browser's viewport with horisontal and vertical scrollbars. And this is on 1920x1080 monitor resolution. The horizontal sizing is especially bad: if a variable is a collection with many members then the UI is stretched very wide.

image

I'm afraid I have to respectfully decline this PR. My time for maintaining this project is limited so I want to focus only on maintaining compatibility with current Python version and fixing bugs if any found, so I'd rather not to introduce additional complexity.

@dhvcc
Copy link
Author

dhvcc commented Mar 2, 2024

Ok sure, I'll fix it in my fork and leave it there 👋

@dhvcc dhvcc closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants