Only save user provided commands in history #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. I will check your PR as soon as I can. I apologize in advance if it may take a long time because of my specific circumstances. |
|
No worries! I'm in no rush |
|
I finally found time to review this PR. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using any of the command buttons ( "next", "continue", etc.), those commands were being saved as part of the command history. I found this to be sort of unintuitive, as I would only want the commands I entered in the input field to be part of the history.
Example workflow:
pp myVariablein the input field to "pretty print" the value ofmyVariablepp myVariableinto the input field. Instead, what happens when I press the up arrow is that the "next line" command is brought inThe changes I make here refactor the code a little such that only commands supplied in the input get saved to the command history.