Updated CMake and used [[maybe_unused]]
if available.
#168
+19
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the top-level,
CMakeLists.txt
I specificed the project language and also put the C++ version language as 14 because inFastor/config/config.h
, the compilation is set to error out if the compiler doesn't at least support C++14.I also modified the test for C++20 because after the release of C++20, the proper way to check for support is to check if
__cplusplus
is defined to be202002L
or not.Finally, I changed the use of the
[[gnu::unused]]
to[[maybe_unused]]
if available and compiler-specific pragmas otherwise, because[[gnu::unused]]
was emitting errorC5030
on MSVC v19.35 (attribute 'gnu::unused' is not recognized
).