Only accept string values for CreditCard

ronanguilloux · Apr 26, 2016 · e9d1d5a · e9d1d5a
1 parent 7d558fd
commit e9d1d5a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/IsoCodes/CreditCard.php b/src/IsoCodes/CreditCard.php
@@ -20,7 +20,7 @@ class CreditCard implements IsoCodeInterface
      */
     public static function validate($creditCard)
     {
-        if (trim($creditCard) === '') {
+        if (!is_string($creditCard) || trim($creditCard) === '') {
             return false;
         }
 

diff --git a/tests/IsoCodes/Tests/CreditCardTest.php b/tests/IsoCodes/Tests/CreditCardTest.php
@@ -30,7 +30,6 @@ public function getValidCreditCards()
             array('4903010000000009'),  //Switch
             array('4111111111111111'),  //Visa
             array('6304100000000008'),  //Laser
-            array(6304100000000008),    //Laser
         );
     }
 
@@ -44,6 +43,8 @@ public function getInvalidCreditCards()
         return array(
             array('CE1EL2LLFFF'),
             array('E31DCLLFFF'),
+            // Valid card but not a string. See: https://github.com/ronanguilloux/IsoCodes/issues/75
+            array(6304100000000008),
             array(''),
             array(' ')
         );