Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate other values than string for CreditCard #93

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Deprecate other values than string for CreditCard #93

wants to merge 3 commits into from

Commits on May 28, 2016

  1. Deprecate other values than string for CreditCard 

    Test for card number `6304100000000008` fails on windows because a number this long can't be stored as an integer.
Instead it becomes a float and when converted into string it is 6.3041E+15 instead of 6304100000000008.

CreditCard::validate should only allow string arguments.

This is done in a BC way and should be updated for next major.
    @soullivaneuh
    soullivaneuh committed May 28, 2016
    Configuration menu
    Copy the full SHA
    1dba1ed View commit details
    Browse the repository at this point in the history

  2. Introduce legacy values for tests

    @soullivaneuh
    soullivaneuh committed May 28, 2016
    Configuration menu
    Copy the full SHA
    e20a08f View commit details
    Browse the repository at this point in the history

  3. Test integer credit cards only on 64 bits system 

    Integer credit card fails on 32bits system because the integer is too long.

Method for 64bits detection: http://stackoverflow.com/a/5424121/1731473
    @soullivaneuh
    soullivaneuh committed May 28, 2016
    Configuration menu
    Copy the full SHA
    f25295d View commit details
    Browse the repository at this point in the history