Ensure font-family declaration is not added more than once #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recently ran into issues using postcss-object-fit-images on a project where the PostCSS processing was done on LESS source files, rather than on the compiled CSS. Since the files were being modified in place, the font-family declaration was being added every time the tool made a pass through the file, meaning after a few compiles we ended up with a huge list of duplicate font-family declarations. This PR adds a filter step, which removes the plugins own output from the existing font family declaration, to ensure that it is never added more than once.
|
@ronik-design is there any chance of this being merged soon please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently ran into issues using postcss-object-fit-images on a project
where the PostCSS processing was done on LESS source files, rather than
on the compiled CSS. Since the files were being modified in place, the
font-family declaration was being added every time the tool made a pass
through the file, meaning after a few compiles we ended up with a huge
list of duplicate font-family declarations.
This PR adds a filter step, which removes the plugins own output from
the existing font family declaration, to ensure that it is never added
more than once.