Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure font-family declaration is not added more than once #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

molovo
Copy link

@molovo molovo commented Dec 7, 2018

I recently ran into issues using postcss-object-fit-images on a project
where the PostCSS processing was done on LESS source files, rather than
on the compiled CSS. Since the files were being modified in place, the
font-family declaration was being added every time the tool made a pass
through the file, meaning after a few compiles we ended up with a huge
list of duplicate font-family declarations.

This PR adds a filter step, which removes the plugins own output from
the existing font family declaration, to ensure that it is never added
more than once.

I recently ran into issues using postcss-object-fit-images on a project
where the PostCSS processing was done on LESS source files, rather than
on the compiled CSS. Since the files were being modified in place, the
font-family declaration was being added every time the tool made a pass
through the file, meaning after a few compiles we ended up with a huge
list of duplicate font-family declarations.

This PR adds a filter step, which removes the plugins own output from
the existing font family declaration, to ensure that it is never added
more than once.
@molovo
Copy link
Author

molovo commented Nov 29, 2019

@ronik-design is there any chance of this being merged soon please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant