chore: Remove RUBY_VERSION condition from gemspec #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition depends on the ruby version which is used to build the roo gem and not the ruby version which is used to install the gem. Luckily the roo-3.0.0 was released with ruby-3.4+, so that these conditional dependencies are registered on rubygems.org. But they also apply when installing on older rubies. Having a condition on the building ruby version could lead to missing dependencies if roo was built with ruby-3.3. There is no possibility in gemspecs to add dependencies which are dependent on the installing ruby version. So it's best to simply remove the condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition depends on the ruby version which is used to build the roo gem and not the ruby version which is used to install the gem.
Luckily the roo-3.0.0 was released with ruby-3.4+, so that these conditional dependencies are registered on rubygems.org. But they also apply when installing on older rubies.
Having a condition on the building ruby version could lead to missing dependencies if roo was built with ruby-3.3. There is no possibility in gemspecs to add dependencies which are dependent on the installing ruby version. So it's best to simply remove the condition.