Repository navigation
Add test for reading Long64_t values - #423
Merged
Merged
Conversation
tree_int64_test.root has a Long64_t branch with values around the 2^32 and 2^53 boundaries and INT64_MIN/MAX, written by tree_int64_test.cxx with ROOT 6.40. tree_int64_test.js reads them back and exits with an error on any mismatch. Covers the ntoi8 fix from root-project#422.
Member
|
Thanks! Exactly that we need. |
Contributor
Author
|
Glad I could contribute a small part in such a prestigious project. Thanks for the review and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
adds the CI test asked for in #422.
Changes:
demo/node/tree_int64_test.root- small tree (5.5 KB) with oneLong64_tbranch, 14 entries: 0, ±1, -2, -2^31, -2^32, -2^32-1, -5e9, -(2^53-1), -2^53, INT64_MIN, 2^32, 2^53-1, INT64_MAXdemo/node/tree_int64_test.cxx- macro that makes the file (ROOT 6.40)demo/node/tree_int64_test.js- reads the branch withtreeProcessand compares every entry to the expected value. on any mismatch it prints FAILURE and doesprocess.exit(1)so the CI job actually goes redjsroot-ci.yml, right afterrntuple_test.jsi checked it both ways. on current master all 14 entries pass. with the old
ntoi8()put back it fails on 4 of them (-2^32 reads as 0, the two values near -2^53 and INT64_MIN are off by 2^32) and exits with 1.