Skip to content

Conversation

@andresailer
Copy link
Contributor

This Pull request:

Changes or fixes:

Fixes the tests environments for tests introduced in #19667 when running with externally build VC

Maybe fixes also other tests that are still failing.

Checklist:

  • tested changes locally

@ferdymercury
Copy link
Collaborator

when running with externally build VC

Related: #20069

@andresailer andresailer marked this pull request as ready for review October 15, 2025 13:10
@andresailer andresailer requested a review from bellenot as a code owner October 15, 2025 13:10
@github-actions
Copy link

Test Results

    22 files      22 suites   3d 19h 1m 32s ⏱️
 3 692 tests  3 692 ✅ 0 💤 0 ❌
79 273 runs  79 273 ✅ 0 💤 0 ❌

Results for commit c4e4f13.

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this change!

@vepadulano vepadulano merged commit c2bf166 into root-project:master Oct 16, 2025
27 checks passed
@andresailer andresailer deleted the fixLCGRootTests branch October 16, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants