[cmake] Install the builtin GLEW headers #20323
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes external use of `TGLIncludes.h`: ``` In file included from src/Fireworks/Core/src/CmsAnnotation.cc:4: .../lcg/root/6.39.1-f6b681b05d584b7e93413a4cff8a643d/include/TGLIncludes.h:21:10: fatal error: GL/glew.h: No such file or directory 21 | #include <GL/glew.h> ```
Test Results 21 files 21 suites 3d 17h 9m 26s ⏱️ For more details on these failures, see this check. Results for commit d7bd655. |
guitargeek
requested changes
Nov 8, 2025
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Hi! I think not installing the GLEW headers was actually a good idea, because we want to migrate away from GLEW anyway.
So I would suggest to properly deprecate them in 6.38, so that they can remain deleted in the 6.40 development branch: #20339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes external use of
TGLIncludes.h: