Skip to content

[tmva][pymva] Deprecate the PyKeras method #20588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guitargeek wants to merge 1 commit into from
Closed

[tmva][pymva] Deprecate the PyKeras method #20588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README/ReleaseNotes/v640/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ The following people have contributed to this new version:
* Comparing C++ `nullptr` objects with `None` in Python now raises a `TypeError`, as announced in the ROOT 6.38 release notes. Use truth-value checks like `if not x` or `x is None` instead.
* The `TGLIncludes.h` and `TGLWSIncludes.h` that were deprecated in ROOT 6.38 and scheduled for removal are gone now. Please include your required headers like `<GL/gl.h>` or `<GL/glu.h>` directly.
* The GLEW headers (`GL/eglew.h`, `GL/glew.h`, `GL/glxew.h`, and `GL/wglew.h`) that were installed when building ROOT with `builtin_glew=ON` are no longer installed. This is done because ROOT is moving away from GLEW for loading OpenGL extensions.
* The TMVA `PyKeras` method is deprecated. It was broken by the API changes in Keras 3, released in November 2023 and part of TensorFlow 2.16 or newer. The `PyKeras` method will be removed in ROOT 6.42 (unless an updated implementation for Keras 3 that matches usage, performance and stability requirements will be found unexpectedly).

## Build System

Expand Down
4 changes: 4 additions & 0 deletions tmva/pymva/src/MethodPyKeras.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@ void MethodPyKeras::InitKeras() {
// initialize first Keras. This is done only here when class has
// all state variable set from options or read from XML file
// Import Keras
Log() << kWARNING
<< "The PyKeras TMVA method was deprecated in ROOT 6.40 and will be removed in ROOT 6.42, since it was broken "
"by the API changes in Keras 3, released in November 2023 and part of TensorFlow 2.16 or newer."
<< Endl;

if (fUseTFKeras)
Log() << kINFO << "Setting up tf.keras" << Endl;
Expand Down
2 changes: 1 addition & 1 deletion tmva/tmva/inc/TMVA/Types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ namespace TMVA {
kPyRandomForest ,
kPyAdaBoost ,
kPyGTB ,
kPyKeras ,
kPyKeras, // deprecated, will be removed in ROOT 6.42
Copy link
Contributor

@silverweed silverweed Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mark this with R__DEPRECATED?

Copy link
Contributor Author

@guitargeek guitargeek Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you can mark individual enum elements as deprecated with R__DEPRECATED (it's only for functions and classes).

Copy link
Contributor

@silverweed silverweed Dec 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you can since C++17! (and we're doing it already, see RNTupleTypes.hxx)

kPyTorch ,
kC50 ,
kRSNNS ,
Expand Down
Loading