Makefile: U7S_PORT_... -> PORT_...
#352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "private" scripts still has the "U7S_" prefix. This is consistent with other variables such as `HOST_IP` and `NODE_NAME`. Signed-off-by: Akihiro Suda <[email protected]>
|
cc @vsoch FYI |
|
Thanks! In the future you can ask me to make these changes, e.g., adding docs, and changing the prefix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "private" scripts still has the "U7S_" prefix.
This is consistent with other variables such as
HOST_IPandNODE_NAME.(We can remove the
U7S_prefix from the "private" scripts too, but they have to be removed at once in another PR)