Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let a session decide if is valid or not #196

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Let a session decide if is valid or not #196

wants to merge 2 commits into from

Conversation

LetoFranco
Copy link
Contributor

Description:

  • Instead of the session manager decide if a session is valid or not, we are going to move that logic to the session

@LetoFranco LetoFranco requested a review from a user February 22, 2022 22:13
glm4
glm4 approved these changes Feb 23, 2022
View reviewed changes
ios-base/Common/Models/Session.swift Outdated Show resolved Hide resolved
@LetoFranco LetoFranco force-pushed the improvement/SessionIsValid branch from 1996dc4 to f07c246 Compare February 23, 2022 16:16
@glm4 glm4 changed the base branch from master to main August 16, 2022 19:41
@LetoFranco LetoFranco force-pushed the improvement/SessionIsValid branch from f07c246 to e49f910 Compare January 27, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glm4 glm4 glm4 approved these changes

@germanStabile germanStabile germanStabile approved these changes

@mato2593 mato2593 mato2593 approved these changes

@pMalvasio pMalvasio pMalvasio approved these changes

@CamilaMoscatelli CamilaMoscatelli Awaiting requested review from CamilaMoscatelli CamilaMoscatelli is a code owner

@kstoletniy kstoletniy Awaiting requested review from kstoletniy

@fpiruzi fpiruzi Awaiting requested review from fpiruzi fpiruzi is a code owner

@LeandroHiga LeandroHiga Awaiting requested review from LeandroHiga

@danialepaco danialepaco Awaiting requested review from danialepaco

@fconelli fconelli Awaiting requested review from fconelli

@DaegoDev DaegoDev Awaiting requested review from DaegoDev

@JUNIOR140889 JUNIOR140889 Awaiting requested review from JUNIOR140889

@SofiaCantero24 SofiaCantero24 Awaiting requested review from SofiaCantero24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LetoFranco @pMalvasio @mato2593 @germanStabile @glm4