Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up irregularities in manylevels_en #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lingtax
Copy link
Contributor

@Lingtax Lingtax commented Jul 14, 2023

  • Trimmed whitespace in " cis woman"
  • Collapsed "non-binary" and "nonbinary" levels

Added 15 entries to manylevels_en and fewlevels_en dictionaries

The full scope of the change is here:

library(tidyverse)
library(gendercoder)
library(usethis)

extension_few <-  c(男 = "man",
   女 = "woman",
   `Intersex female` = "sex and gender diverse",
   `.female` = "woman",
   `Trans female` = "woman",
   `AFAB non binary` = "sex and gender diverse",
   `Non binary/ trans masc` = "sex and gender diverse",
   `Gender non-conforming` = "sex and gender diverse",
   Demiboy = "sex and gender diverse",
   `Female/gender fluid` = "sex and gender diverse",
   `cis woman` = "woman",
   `female.`  = "woman",
   `Female born (sex and gender diverse)` = "sex and gender diverse",
   `She/they (AFAB)` = "sex and gender diverse", 
   `masculine sex and gender diverse` = "sex and gender diverse")

extension_many <-  c(男 = "man",
   女 = "woman",
   `Intersex female` = "intersex woman",
   `.female` = "woman",
   `Trans female` = "transgender woman",
   `AFAB non binary` = "nonbinary",
   `Non binary/ trans masc` = "nonbinary",
   `Gender non-conforming` = "nonbinary",
   Demiboy = "sex and gender diverse",
   `Female/gender fluid` = "genderfluid",
   `cis woman` = "woman",
   `female.`  = "woman",
   `Female born (non-binary)` = "nonbinary",
   `She/they (AFAB)` = "nonbinary", 
   `masculine non-binary` = "nonbinary")

manylevels_en <- manylevels_en %>% 
  str_trim() %>% 
  str_remove("-") %>% 
  c(extension_many)
  
fewlevels_en <-  c(fewlevels_en, extension_few)

use_data(manylevels_en, overwrite = TRUE) 
use_data(fewlevels_en, overwrite = TRUE) 

 - Trimmed whitespace in " cis woman"
 - Collapsed "non-binary" and "nonbinary" levels

Added 15 entries to manylevels_en and fewlevels_en dictionaries
@Lingtax Lingtax requested a review from ekothe July 14, 2023 05:47
@Lingtax
Copy link
Contributor Author

Lingtax commented Jul 19, 2023

ok, so apparrently I have made a huge mistake in updating the dictionaries that breaks the whole core function. I might have to go back to scratch and try again.
The non ASCII characters while working in interactive are not working in the package though as an additional note so one way or another they'll come out

@YaoxiangLi YaoxiangLi requested review from YaoxiangLi and removed request for ekothe February 23, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant