Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ncbi endpoint #73

Closed
wants to merge 1 commit into from
Closed

Conversation

KaiAragaki
Copy link

The NBCI taxonomy endpoint must have changed at one point, causing calls to db_download_ncbi to fail. This fixes this.

Related Issue

May be an alternate solution to #72 (since the impetus was timeout on download)

Examples

Might be wise to add some kind of test like

"ftp://ftp.ncbi.nlm.nih.gov/pub/taxonomy/taxdmp.zip" |> curl_fetch_memory()

And test for no error. Might also be wise to somehow link the test URL and the package function URL so that a change in the function would invalidate the test. Seemed kinda out of scope though and also I'm not terribly sure how to do this well, so we're flying testless.

The NBCI taxonomy endpoint must have changed at one point, causing calls
to `db_download_ncbi` to fail. This fixes this.
@stitam
Copy link
Collaborator

stitam commented Apr 9, 2024

Thanks @KaiAragaki for opening this PR and apologies for the delay in my response.

I have checked both URLs in my browser and their contents seem to be identical (which is strange):

https://ftp.ncbi.nih.gov/pub/taxonomy/
https://ftp.ncbi.nlm.nih.gov/pub/taxonomy/

The URL which is currently in the package seems to be working on my end. I wonder if this was just a temporary issue at NCBI rather than a permanent change in the URL? Can you please check if the original URL works on your end now?

@KaiAragaki
Copy link
Author

@stitam Thanks so much for your reply!

It looks like it works now - maybe there was a broken redirect that got fixed? Maybe I'm just dumb. Either way, I'll close this PR. Thank you!

@KaiAragaki KaiAragaki closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants