Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #67 #69

Merged
merged 4 commits into from
Aug 4, 2024
Merged

fix #67 #69

merged 4 commits into from
Aug 4, 2024

Conversation

pachadotdev
Copy link
Contributor

No description provided.

@jeroen
Copy link
Member

jeroen commented Aug 4, 2024

We can probably fix the warning by using int i instead of size_t i in the for loop.

@pachadotdev
Copy link
Contributor Author

We can probably fix the warning by using int i instead of size_t i in the for loop.

I edited that!

it is practically the same, the number of languages will never create an integer overflow and that the performance impact is zero

@jeroen
Copy link
Member

jeroen commented Aug 4, 2024

I meant that that way you can keep the langs.size() in the loop and keep the diff very minimal.

@pachadotdev
Copy link
Contributor Author

I meant that that way you can keep the langs.size() in the loop and keep the diff very minimal.

yes, my PR saves 1 duplicated computation

@pachadotdev
Copy link
Contributor Author

I meant that that way you can keep the langs.size() in the loop and keep the diff very minimal.

done

@jeroen
Copy link
Member

jeroen commented Aug 4, 2024

Can you fix the merge conflict

@pachadotdev
Copy link
Contributor Author

Can you fix the merge conflict

done, thx!

@jeroen jeroen merged commit 7688528 into ropensci:master Aug 4, 2024
8 checks passed
@pachadotdev pachadotdev deleted the cppcomparison branch August 7, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants