Fix install.sh crash when piped from curl#6
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BASH_SOURCE[0]is unbound when bash reads from stdin (thecurl ... | sudo bashpath), andset -euo pipefailmade it an immediate fatal errorinstalllocal unit files that don't exist on the target machineBASH_SOURCE[0]with:-soSCRIPT_DIRdefaults to""when piped, then downloads unit files (game-over-man.service,game-over-man.timer) andenv.examplefrom GitHub when no local script directory is availableMirrors the fix from rorpage/now-you-noaa#4.
Test plan
curl -fsSL https://raw.githubusercontent.com/rorpage/game-over-man/main/deploy/systemd/install.sh | sudo bashno longer crashes on line 14sudo bash deploy/systemd/install.shfrom a local clone still uses local unit files (no unnecessary downloads)REPO_ROOTlogic) still works from a local clone when no release binary is found🤖 Generated with Claude Code