Skip to content

Commit 36bba03

Browse files
Remove double storage of limits
1 parent 84a0c5c commit 36bba03

File tree

1 file changed

+3
-9
lines changed
  • control_toolbox/include/control_toolbox

1 file changed

+3
-9
lines changed

control_toolbox/include/control_toolbox/pid.hpp

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -291,8 +291,6 @@ class Pid
291291
d_gain_(d),
292292
u_max_(u_max),
293293
u_min_(u_min),
294-
i_max_(antiwindup_strat.i_max),
295-
i_min_(antiwindup_strat.i_min),
296294
antiwindup_strat_(antiwindup_strat)
297295
{
298296
}
@@ -328,13 +326,9 @@ class Pid
328326
antiwindup_strat_.print();
329327
}
330328

331-
double p_gain_ = 0.0; /**< Proportional gain. */
332-
double i_gain_ = 0.0; /**< Integral gain. */
333-
double d_gain_ = 0.0; /**< Derivative gain. */
334-
double i_max_ =
335-
std::numeric_limits<double>::infinity(); /**< Maximum allowable integral term. */
336-
double i_min_ =
337-
-std::numeric_limits<double>::infinity(); /**< Minimum allowable integral term. */
329+
double p_gain_ = 0.0; /**< Proportional gain. */
330+
double i_gain_ = 0.0; /**< Integral gain. */
331+
double d_gain_ = 0.0; /**< Derivative gain. */
338332
double u_max_ = std::numeric_limits<double>::infinity(); /**< Maximum allowable output. */
339333
double u_min_ = -std::numeric_limits<double>::infinity(); /**< Minimum allowable output. */
340334
AntiWindupStrategy antiwindup_strat_; /**< Anti-windup strategy. */

0 commit comments

Comments
 (0)