-
Notifications
You must be signed in to change notification settings - Fork 85
Add AsyncFunctionHandlerParams initialization through ROS parameters #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AsyncFunctionHandlerParams initialization through ROS parameters #402
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #402 +/- ##
==========================================
- Coverage 86.61% 85.42% -1.20%
==========================================
Files 17 17
Lines 1390 1441 +51
Branches 117 135 +18
==========================================
+ Hits 1204 1231 +27
- Misses 111 121 +10
- Partials 75 89 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in principle LGTM.
Do you plan to update ros-controls/ros2_control#2477 with this?
Not really |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…(backport #402) (#413) Add AsyncFunctionHandlerParams initialization through ROS parameters (#402) (cherry picked from commit 37a17bc) Co-authored-by: Sai Kishor Kothakota <[email protected]>
I've added a way to initialize the current parameter from the ROS nodes directly, much easier when using with nodes and controllers