Skip to content

Conversation

saikishor
Copy link
Member

I've added a way to initialize the current parameter from the ROS nodes directly, much easier when using with nodes and controllers

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 64.86486% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.42%. Comparing base (2cf4b74) to head (dcca6db).

Files with missing lines Patch % Lines
.../include/realtime_tools/async_function_handler.hpp 56.66% 5 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
- Coverage   86.61%   85.42%   -1.20%     
==========================================
  Files          17       17              
  Lines        1390     1441      +51     
  Branches      117      135      +18     
==========================================
+ Hits         1204     1231      +27     
- Misses        111      121      +10     
- Partials       75       89      +14     
Flag Coverage Δ
unittests 85.42% <64.86%> (-1.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ealtime_tools/test/test_async_function_handler.cpp 100.00% <100.00%> (ø)
.../include/realtime_tools/async_function_handler.hpp 74.87% <56.66%> (-7.40%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in principle LGTM.

Do you plan to update ros-controls/ros2_control#2477 with this?

@saikishor
Copy link
Member Author

in principle LGTM.

Do you plan to update ros-controls/ros2_control#2477 with this?

Not really
I've just added it for future purposes. Maybe for the controller interface class

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikishor saikishor merged commit 37a17bc into ros-controls:master Sep 23, 2025
26 checks passed
@saikishor saikishor deleted the add/async_params/initialization/parameters branch September 23, 2025 12:25
@saikishor saikishor added backport-jazzy Triggers PR backport to ROS 2 jazzy. and removed backport-jazzy Triggers PR backport to ROS 2 jazzy. labels Sep 25, 2025
mergify bot pushed a commit that referenced this pull request Sep 25, 2025
saikishor added a commit that referenced this pull request Sep 25, 2025
…(backport #402) (#413)

Add AsyncFunctionHandlerParams initialization through ROS parameters (#402)

(cherry picked from commit 37a17bc)

Co-authored-by: Sai Kishor Kothakota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-jazzy Triggers PR backport to ROS 2 jazzy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants