-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix async controllers deactivation regime #2017
Fix async controllers deactivation regime #2017
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2017 +/- ##
==========================================
+ Coverage 89.30% 89.32% +0.01%
==========================================
Files 139 139
Lines 15500 15601 +101
Branches 1318 1324 +6
==========================================
+ Hits 13843 13935 +92
- Misses 1154 1160 +6
- Partials 503 506 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…ctivation request
788a253
to
a1c713c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7e8750a
into
ros-controls:master
Right now, we have the
wait_for_trigger_update_to_finish
method that waits for the current cycle to finish, but the problem would be the case when it is finished and a new cycle is triggered that means, even the previous cycle is finished, a new cycle might be triggered and this might cause segmentation fault, as the release interfaces is already called by deactivation method. This PR ensure to fix the issue