Features added & major rewrite. #42
Conversation
Refactored axis.py to use OOP in a more suitable way. Added the possibility to specify compression and FPS levels.
…a standby camera.
…nes are retained for BC. Also changed the resolution select to use the standard CIF resolution names.
Now, both v2 and v3 VAPIX are supported.
Also, when the driver cannot connect to VAPIX, it now tries forever to connect again.
I tried to make the parameters reflect the real state of things, but it seems it ïs a bit buggy - the most if one uses the deprecated PTZ config together with Camera.
…led TF publishing. Added a simple way how to display both camera image and camera pose in RViz.
Not very much configurable as of now, but it works.
…ed (requires anonymous PTZ control, or providing credentials).
…- the hostname was therefore prepended twice.
It still needs more refactoring so that it doesn't use the self._axis variable.
It still needs more refactoring so that it doesn't use the self._axis variable.
|
Hey I tried, If I send a 0.0 I get: If I send 0.00001: Seems like the 0.0 is treated as a "not filled field" value, or something. |
… to really stop the camera.
|
@awesomebytes Thanks for the info, I hope the bug is fixed now. Please, try to update your branch and test it again. |
|
I've been watching these changes with interest since I use Axis PTZ cameras In a week or so I'll be receiving a new Axis 214 camera to try out with On Thu, Oct 29, 2015 at 9:00 PM, Martin Pecka [email protected]
Jeff Schmidt |
|
Jeff, according to the documentation, your P5512-E camera should also support the VAPIX API and therefore should be supported by the driver. I think we can debug the cause. I just don't think we need to do the communication here. I left you an email message and let's continue there ;) |
Now the proposed changes to ROS wiki can be saved and discussed somewhere until they are published. To "compile" the wiki page, just open any ROS wiki page, click Edit (Text), paste the contents there and click Preview.
…namic_reconfigure classes.
…am.cfg. This uses kind of a hack from dynamic_reconfigure_tools, but it works well.
|
I did an architectural change to the way how resolutions are handled. Because there are going to be numerous resolutions for different Axis products, it seemed to me impractical to create a list of supported resolutions, from which only a few would be supported by particular camera models. So in the last 2 commits I did a little hack that exploits the I also improved the error messages when connecting to the API doesn't succeed. Now, it the camera returns 401 Unauthorized, the log message instructs the developer to provide a username/password or to allow anonymous access. |
…upports them. Otherwise, it prevented the driver to run on e.g. cameras with no absolute iris control (just autoiris).
Added the option to choose a resolution by specifying only one dimension.
…wares 5.0-5.6 and the newer ones.
This may happen when you loop a bag file and stream the live camera at the same time.
This is the easiest fix for selecting our package over the ROS-bundled one. This might be a bit hacky, but bumping the version does make sense anyway.
Bumped the version to 0.3.0
|
Status? |
|
Conflicts of this branch with master should be easy to resolve. However, I'm still not sure the maintainers (if there are still any) are interested in this different approach. Maybe forking and creating an alternative driver would be better? |
|
Hi, this package was orphaned for a long time. Clearpath has just (re-)assumed maintainership. We're looking into this now and will likely be merging it soon. |
|
Wow. Haven't expected anyone will ever resurrect this :) I'm no longer actively using the camera, so I can't tell whether the code still works or if it is compatible with newer models. |
|
We'll make sure things are still working before merging things into master. But given how long this project has been dormant, any improvements are welcome. |
|
I finally had a chance to try out your changes with an Axis M5525
The HTTPError messages only start appearing once I add the image topic in rviz. |
|
Thanks for testing. Could you try to get some deeper debug info? What are the HTTP errors about? Can you try to change the source code so that the content of the error is displayed? |
|
I'll do my best, but I don't have access to a camera right now; I did as much testing as I could before one of our integrators took the camera away to install it on a customer's robot. I'm working on getting longer-term access to a camera to do some more thorough work on this driver soon though. |
Hi guys, in our TRADR project we use an Axis 214 PTZ cam on a mobile robotic platform running ROS.
So we started using this driver, but as time went, we needed more features than it currently provides.
We were thinking about the best way how to add the features we need, and finally we agreed that the current API has some flaws (e.g. mixing focus/brightness control together with pan/tilt/zoom) we would also like to fix.
So we started a complete rework of the driver, and we achieved the following as a result:
Please, take a look at the new code (looking at the changelog is probably not a good idea since we changed too much). Tell us if you like the changes we made, and, please, test it with your existing applications utilizing the old API to be sure the backwards-compatibility layer works as expected.
Also, please, tell us if the backwards compatibility layer is needed at all. If it weren't, some more structural changes towards clean design could be done.
Thank you very much and hope you'll like it.