Add support for Phidgets Current sensors#148
Conversation
| <maintainer email="martin.guenther@dfki.de">Martin Günther</maintainer> | ||
| <maintainer email="clalancette@openrobotics.org">Chris Lalancette</maintainer> | ||
|
|
||
| <license>BSD</license> | ||
|
|
||
| <author>Chris Lalancette</author> |
There was a problem hiding this comment.
Should the maintainer and/or author be me, even though I wrote essentially no code?
There was a problem hiding this comment.
By "I wrote essentially no code", you mean that you simply followed the pattern of the other phidgets and did some text replacement? That still counts as writing code, and the author should be you. It's better to leave the maintainer fields as is, because it's @clalancette and me who will be maintaining the code once it's merged. I think the maintainer field is parsed by the build farm to send out emails on build failures, and Chris and me want to get those. :)
mintar
left a comment
mintar
left a comment
There was a problem hiding this comment.
Very nice pull request, almost done!
I've suggested some tiny changes. Also, don't forget to put your name into the author tag.
Also, there's a CI error because of the failing style check. Simply install pre-commit as described here, run pre-commit run -a, and it will reformat your code properly.
| PhidgetCurrentInput_getCurrent(ci_handle_, &sensor_value); | ||
| if (ret != EPHIDGET_OK) | ||
| { | ||
| throw Phidget22Error("Failed to get analog sensor value", ret); |
| PhidgetCurrentInput_setDataInterval(ci_handle_, data_interval_ms); | ||
| if (ret != EPHIDGET_OK) | ||
| { | ||
| throw Phidget22Error("Failed to set analog data interval", ret); |
|
@lights0123 : Could you address the requested changes, so we can merge this? |
This will be auto-generated on release
--------- Co-authored-by: Martin Günther <martin.guenther@dfki.de>
3 participants
This is really just a find/replace from the phidgets_analog_inputs package.