Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better validation of ip address for set_urg_ip #64

Open
wants to merge 1 commit into
base: indigo-devel
Choose a base branch
from
Open

Better validation of ip address for set_urg_ip #64

wants to merge 1 commit into from

Commits on Apr 29, 2020

  1. Better validation of ip address for set_urg_ip 

    Use the ipaddress library to validate the given ip-addresses.

Don't use a loop to fill up missing zeros.

Before the given ip was checked for their format
which means that the format is like AAA.BBB.CCC.DDD.
But it was never checked if it is actually a valid ip and not only
in the correct format.

Parsing it with ipaddress will ensure that the given ip is valid.

Using zfill to fill missing zeros just feels nicer.
    @worldpotato
    worldpotato committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    025361a View commit details
    Browse the repository at this point in the history