Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMake imported targets to link Poco #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jan 21, 2025

The use of CMake imported targets to link Poco has the following advantages:

CMake Error in build/_deps/abb_librws-src/CMakeLists.txt:
  Target "abb_librws" INTERFACE_INCLUDE_DIRECTORIES property contains path:

    "C:/Users/gcorrenti/idjl-software/.pixi/envs/idjllancedeformationenv/Library/include"

  which is prefixed in the source directory.

when the abb_librws is installed in a folder that is contained in source folder of the cmake project that is calling find_package(abb_librws), as it commonly happens if Poco is installed in a project-oriented package manager, for example pixi or vcpkg when used in manifest mode.

I checked in Ubuntu and Poco imported targets are available in Poco's apt packages at least since Ubuntu 18.04, so I think we should be safe w.r.t. to backward compatibility.

@traversaro
Copy link
Contributor Author

fyi @Luca0101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant