Use CMake imported targets to link Poco #171
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of CMake imported targets to link Poco has the following advantages:
It generated relocatable cmake config files (see https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#creating-relocatable-packages)
It does not raise an error like:
when the
abb_librws
is installed in a folder that is contained in source folder of the cmake project that is callingfind_package(abb_librws)
, as it commonly happens if Poco is installed in a project-oriented package manager, for example pixi or vcpkg when used in manifest mode.I checked in Ubuntu and Poco imported targets are available in Poco's apt packages at least since Ubuntu 18.04, so I think we should be safe w.r.t. to backward compatibility.