Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPX1950 Support Package #521

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

EricMarcil
Copy link
Contributor

Added MPX1950 Support Package

Added MPX1950 Support Package
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed review.

I've left a couple of in-line comments/questions.

One additional comment: link_2_l.dae appears to have some issue with normals or other rendering artefacts:

image

Flatten surface of link_2_l.dae
Removed erroneous reference to DT and XP models
@EricMarcil
Copy link
Contributor Author

@gavanderhoorn Made the requested changes. Please review.

ted-miller
ted-miller previously approved these changes Dec 20, 2023
Copy link
Contributor

@ted-miller ted-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on Eric's testing

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also based on @EricMarcil's testing and @ted-miller's additional review.

@gavanderhoorn gavanderhoorn merged commit 00b8b82 into ros-industrial:kinetic-devel Jan 31, 2025
@gavanderhoorn
Copy link
Member

Thanks @EricMarcil

@EricMarcil EricMarcil deleted the MPX1950 branch January 31, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants