MPX1950 Support Package#521
Merged
gavanderhoorn merged 3 commits intoros-industrial:kinetic-develfrom Jan 31, 2025
Merged
Conversation
Added MPX1950 Support Package
gavanderhoorn
requested changes
Jun 28, 2023
Member
gavanderhoorn
left a comment
gavanderhoorn
left a comment
There was a problem hiding this comment.
Apologies for the delayed review.
I've left a couple of in-line comments/questions.
One additional comment: link_2_l.dae appears to have some issue with normals or other rendering artefacts:
Flatten surface of link_2_l.dae Removed erroneous reference to DT and XP models
Contributor
Author
|
@gavanderhoorn Made the requested changes. Please review. |
ted-miller
previously approved these changes
Dec 20, 2023
Contributor
ted-miller
left a comment
ted-miller
left a comment
There was a problem hiding this comment.
Approving based on Eric's testing
gavanderhoorn
approved these changes
Jan 31, 2025
Member
gavanderhoorn
left a comment
gavanderhoorn
left a comment
There was a problem hiding this comment.
Also based on @EricMarcil's testing and @ted-miller's additional review.
Member
|
Thanks @EricMarcil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added MPX1950 Support Package