-
Notifications
You must be signed in to change notification settings - Fork 201
HC20DTP and HC30PL Update #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The HC20 package was updated with the HC20DTP and HC30PL variant. HC20 visual meshes were changed from .stl to .dae format to improve rendering.
a8cee48
to
5ebcc03
Compare
High-level comment: could you please use multiple commits in future PRs when changing multiple things and adding support for new variants/series? |
@gavanderhoorn Yes, I will try do split them up in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as requested changes while we discuss my comments.
Added Flange link/joint between the Joint_6_t and the tool0
Added note about HC30PL limitation about the flange needing to point downward which cannot be accounted for by the URDF file. Increase B-axis motion so that compounded angles of the L,U and B axes can keep the flange model with 15 degrees of the ground. Reverted package version to 0.1.0
In our repo we had added (identical) opw configs for HC20 DT and HC20 DTP: We also renamed the hc20 files to hc20dt, which you probably don't want to copy: |
Added opw_parameters files
@cjue I've added the opw_parameters files based on your files. Can you please double check the one for the hc30pl that I added. I believe that the -90 offset for the 5th joint is the only change required. |
MoveIt accepts the opw config for the HC30 PL, I could move the robot and the OPW correctly corresponds to the URDF file. About the HC30 urdf file:
Can you explain that a bit more? Currently the URDF in the PR allows +/-15° for joint_4_r, matching the datasheet, while allowing +/- 180° for joint_5_b, where the datasheet would also dictate +/-15°. Won't the controller abort any trajectory that moves outside the +/- 15 ° range for J5? |
The +/- 15 degrees is relative to the floor. But you are correct, I'll need to correct the B-axis range. I forgot to account for the 90 deg offset. So the range is -90 to 270. |
Correct on the HC30PL motion and speed range (R and B axes)
I've updated the hc30pl based on the limits from the parameter files. So the new values will be correct. The user will need to insure that the robot flange remains +/- 15 degrees relative to the ground. I haven't tested in MotoRos but normally the controller will give an alram 4420 SPECIAL SOFTLIMIT [R1: MAX B] at execution time when the robot is commanded to move outside of the 15 deg position. |
Sounds reasonable 👍 It's quite confusing that the datasheet differs this much from the URDF and the parameter files without specifying that the +/- 15° constraint is relative to the floor. |
1c4ca70
to
c214ddb
Compare
Co-authored-by: Christian Jülg <[email protected]>
Thank you @EricMarcil for the updates and thanks @cjue for the additional comments and contributions 👍 |
The HC20 package was updated with the HC20DTP and HC30PL variant. HC20 visual meshes were changed from .stl to .dae format to improve rendering.