-
Notifications
You must be signed in to change notification settings - Fork 111
Fixes required to follow tutorial #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
bf7b165
3bf2085
e7737a1
8e5fcfd
0017fae
6fd6644
cdfc112
a06f2e1
afb1099
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -104,7 +104,7 @@ Bus configuration creation | |
| .. code-block:: yaml | ||
|
|
||
| options: | ||
| dcf_path: install/{package_name}/share/{package_name}/config/{bus_config_name} | ||
| dcf_path: "@BUS_CONFIG_PATH@" | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is recommended I believe
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this is correct.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, depends if #403 gets merged first 🙂 |
||
|
|
||
| Then you need to define your master. | ||
|
|
||
|
|
@@ -126,7 +126,7 @@ Bus configuration creation | |
| .. code-block:: yaml | ||
|
|
||
| nodes: | ||
| - [unique slave name]: | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should not be a list but a map. |
||
| [unique slave name]: | ||
| node_id: [node id] | ||
| package: [ros2 package where to find the driver] | ||
| driver: [qualified name of the driver] | ||
|
|
@@ -141,8 +141,7 @@ Create a launch folder in your package directory and a launch file. | |
|
|
||
| .. code-block:: console | ||
|
|
||
| mkdir launch | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This directory was already created above. |
||
| touch {...}.launch.py | ||
| touch launch/{...}.launch.py | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added |
||
|
|
||
| Add the following code: | ||
|
|
||
|
|
@@ -216,26 +215,8 @@ Finally we need to adjust the CMakeLists.txt file to pick everything up correctl | |
| cogen_dcf({bus_config_name}) | ||
|
|
||
| install(DIRECTORY | ||
| launch/ | ||
| DESTINATION share/${PROJECT_NAME}/launch/ | ||
| launch | ||
| DESTINATION share/${PROJECT_NAME} | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is simply a cleanup. All other tutorials use this syntax, result is the same but this allows for more folders. |
||
| ) | ||
|
|
||
| install(DIRECTORY | ||
| launch_tests/ | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This directory simply does not exist. |
||
| DESTINATION share/${PROJECT_NAME}/launch_tests/ | ||
| ) | ||
|
|
||
|
|
||
| if(BUILD_TESTING) | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is just noise on the tutorial. |
||
| find_package(ament_lint_auto REQUIRED) | ||
| # the following line skips the linter which checks for copyrights | ||
| # comment the line when a copyright and license is added to all source files | ||
| set(ament_cmake_copyright_FOUND TRUE) | ||
| # the following line skips cpplint (only works in a git repo) | ||
| # comment the line when this package is in a git repo and when | ||
| # a copyright and license is added to all source files | ||
| set(ament_cmake_cpplint_FOUND TRUE) | ||
| ament_lint_auto_find_test_dependencies() | ||
| endif() | ||
|
|
||
| ament_package() | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not specifying it in
bus.ymlgives an error.