Skip to content

CMake: Harden yaml-cpp usage #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roncapat wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CMake: Harden yaml-cpp usage #397

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e60a4f9
CMake: Harden yaml-cpp usage
roncapat Dec 3, 2025
45b9304
Apply suggestion from @roncapat
roncapat Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions canopen_core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ find_package(rclcpp REQUIRED)
find_package(rclcpp_components REQUIRED)
find_package(rclcpp_lifecycle REQUIRED)
find_package(yaml_cpp_vendor REQUIRED)
find_package(yaml-cpp REQUIRED)
include(ConfigExtras.cmake)

set(dependencies
Expand Down Expand Up @@ -57,9 +58,13 @@ ament_target_dependencies(node_canopen_driver
rclcpp_lifecycle
lely_core_libraries
yaml_cpp_vendor
yaml-cpp
canopen_interfaces
Boost
)
target_link_libraries(node_canopen_driver
yaml-cpp::yaml-cpp
)

add_library(node_canopen_master
SHARED
Expand All @@ -77,11 +82,12 @@ ament_target_dependencies(node_canopen_master
rclcpp
rclcpp_lifecycle
lely_core_libraries
yaml_cpp_vendor
canopen_interfaces
Boost
)

target_link_libraries(node_canopen_master
yaml-cpp::yaml-cpp
)

add_library(device_container
SHARED
Expand All @@ -107,7 +113,7 @@ ament_target_dependencies(device_container
target_link_libraries(device_container
node_canopen_master
node_canopen_driver
yaml-cpp
yaml-cpp::yaml-cpp
)

add_executable(device_container_node
Expand Down