Feat(mqtt_client) : Add Unsubscribe method #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauk2
approved these changes
Dec 5, 2025
Member
sauk2
left a comment
sauk2
left a comment
There was a problem hiding this comment.
Tests are passing locally. Merging this in 🚀
sauk2
pushed a commit
to sauk2/vda5050_client
that referenced
this pull request
Dec 10, 2025
* Add unsubscribe methods * Add unsubscribe tests * clang format fixes
sauk2
pushed a commit
to sauk2/vda5050_client
that referenced
this pull request
Dec 10, 2025
* Add unsubscribe methods * Add unsubscribe tests * clang format fixes Signed-off-by: Saurabh Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple
unsubscribemethod to the mqtt_client implementation. It is required for the vda5050 master when onboarding/offboarding AMRs gracefully.Added some simple tests as well.