fix(ActionParameter): Change value type to string #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shawn Chan <[email protected]>
sauk2
approved these changes
Nov 17, 2025
Member
sauk2
left a comment
sauk2
left a comment
There was a problem hiding this comment.
Thanks for the quick fix! Tested it locally and it works
Suggested a small change after which it can be merged
Comment on lines
880
to
888
Member
There was a problem hiding this comment.
Just noticed that there is a repeated block for Action. Let's remove this
Signed-off-by: Shawn Chan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the bug as described in #19. The type in the
valuefield ofActionParameter.msgis now of typestringinstead of a custom msg type.