Fix handling of path-only dependencies - #15
Merged
Merged
Conversation
This scenario is completely unsupported when crates.io is used, so we have some room to decide how to interpret a dependency specified only by path. If both a version and a path are present, a crate packaged for crates.io will carry the version number only, and pallet-patcher uses that version number for search and resolution as you might expect. This change interprets the version constraint as "any version", or "*", when there isn't any version number given in the dependency constraints at all.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 81.81% 81.81%
=======================================
Files 6 6
Lines 264 264
Branches 68 68
=======================================
Hits 216 216
Misses 29 29
Partials 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Blast545
approved these changes
Jun 25, 2026
Blast545
left a comment
Blast545
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. I'm surprised we didn't catch that one earlier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This scenario is completely unsupported when crates.io is used, so we have some room to decide how to interpret a dependency specified only by path. If both a version and a path are present, a crate packaged for crates.io will carry the version number only, and pallet-patcher uses that version number for search and resolution as you might expect.
This change interprets the version constraint as "any version", or "*", when there isn't any version number given in the dependency constraints at all.
For clarity, under the existing code, the scenario will always result in a backtrace.