Resolve vendored crates from a registry scoped to their own package - #19
Open
Blast545 wants to merge 1 commit into
Open
Resolve vendored crates from a registry scoped to their own package#19Blast545 wants to merge 1 commit into
Blast545 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 80.97% 83.09% +2.12%
==========================================
Files 6 6
Lines 268 278 +10
Branches 68 73 +5
==========================================
+ Hits 217 231 +14
+ Misses 32 30 -2
+ Partials 19 17 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to make pallet-patcher a bit smarter in order to find vendored crates in a succesful manner. Before this PR, pallet-patcher takes the different registries with just order priority and gets the first dependency matching what its searching for.
Vendoring is not completely aligned with this mechanism since we don't want the option to find packages in the "vendored" subtree for a specific crate, but we don't want to make it available for other crates it's not a part of.
This PR introduces:
location/vendoris added as a place to search for crates. In the second, if we are iterating for a dependency that's part of a vendored tree, we look for them in the vendored tree.Vendored crates still have the latest priority, so crates found in the search_paths will take priority when searching for dependencies.
The two added tests specify the type of resolution we want to achieve with this PR.