Implement my own file change detection. #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearsandwich
added a commit
that referenced
this pull request
Apr 15, 2022
|
Changes looks reasonable to me. Is there a any test run on top of these changes to check if it runs fine? |
This has been merged into #150 (which was breaking under the existing change detection) and is being used for that PR. |
j-rivero
approved these changes
Apr 19, 2022
nuclearsandwich
added a commit
that referenced
this pull request
Apr 22, 2022
* Reformat with sed script.
s/^((Package/(Package/
s/^Package/ Package/
s/Package (% =/Package (= /
s/^\$Version/), $Version/
s/)), /) /
s/)) |/) |/
* Update config using the latest script version.
* Merge changes from #151.
* Try tr.
* Try merge base.
* Manual cleanup.
* Updates using generator script.
* Revert buster changes.
* Update to correct citadel versions of packages.
* Re-add ignition tools.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept hitting jitterbit/get-changed-files#42 when working on recent PRs. So I decided to see what it would take to get my own approach in.
The answer, it turned out was not much in terms of trickery but a fair bit of tweaking to account for the GitHub actions environment. I am in favor of this "just use git" but it does mean fetching a deep clone rather than a shallow one. For this project that shouldn't be too punishing though.