nao_apps behaviors.py didn't exit if the connection was not establisehed with the proxy #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…behaviors.py nao_leds.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request is to shut down the process if the connection is not established with the naoqi proxy.
I'm launching all the nodes using the systemd.service. Not shutting down the process when it fails to establish connection with the proxy leaves the roslaunch running. So, the service cannot be restarted automatically.
I've modified only nao_alife.py nao_behaviors.py and nao_leds.py because the rest of the nodes already check the connection.
Cheers,
Felip