Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pepper_gazebo_plugin] add base_footprint2 to use planar move plugin #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kochigami
Copy link
Contributor

@kochigami kochigami commented Dec 1, 2016

I'd like to make Pepper move by /cmd_vel in the gazebo world.

I added planar move plugin in pepper.urdf and pepperGazebo.xacro instead of diff drive .
However, just using it causes pepper's weird movement as discussed in #28.
In order to avoid it, I added base_footprint2 near base_link in pepper_torso.xacro.

As for planar move plugin, I'd like to use ros-simulation/gazebo_ros_pkgs#372 .
In addition, the parameter of launch_control_trajectory_all in pepper_gazebo_plugin_Y20.launch (in pepper_gazebo_plugin) has to be set false.
[Edited] to use this without changing launch_control_trajectory_all to false,
I sent ros-naoqi/pepper_virtual#7

The only problem is pepper bends down and gradually returns to the original pose when we send a big value like

rostopic pub /cmd_vel geometry_msgs/Twist "linear:
  x: 0.8
  y: 0.8
  z: 0.0
angular:
  x: 0.0
  y: 0.0
  z: 0.0" -1

If there is any problem, please let me know.
(I'm wondering whether there are other programs which use pepper.urdf, pepper_torso.xacro...)

Thank you very much @ k-okada.

@@ -2279,20 +2279,35 @@
</sensor>
</gazebo>
-->
<!-- <gazebo> -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove this commented part?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah non, this urdf file should be regenerated from macro, so if we remove this code from macro than it won't be here

@@ -684,20 +684,36 @@
</gazebo>
-->
<!-- Drive controller -->
<!-- <gazebo> -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove this commented part?

</link>
<joint name="base_footprint_fixedjoint" type="fixed">
<parent link="base_link"/>
<child link="base_footprint2"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really necessary to have this link?

@kochigami
Copy link
Contributor Author

Thank you very much for your comment.

Sorry, I haven't completed this pull-request yet...
When I complete it, I'll modify the lines you mentioned.

@jokla
Copy link

jokla commented Jan 30, 2017

Hi @kochigami !
I would like to command Pepper with /cmd_vel in the gazebo world too.
Right now if I send a command in /cmd the robot doesn't behave as expected.

I am a bit lost with all the pull requests. Have you succeeded to make it work?

Thanks!

@kochigami
Copy link
Contributor Author

Hi, @jokla

I'm very sorry for my late reply.
I think ros-simulation/gazebo_ros_pkgs#372 and this pull-request make /cmd_vel available.

I confirmed it in ubuntu 14.04 and ros indigo.

roslaunch pepper_gazebo_plugin pepper_gazebo_plugin_Y20.launch
(on a terminal)
rostopic pub /cmd_vel geometry_msgs/Twist 
"linear:
      x: 0.1
      y: 0.0
      z: 0.0
    angular:
      x: 0.0
      y: 0.0
      z: 0.0" -1

I'd like to update this pull-request if I find a new way though. Sorry for that.

@nlyubova
Copy link
Member

@kochigami should we merge it in this case?

@k-okada
Copy link
Member

k-okada commented Feb 22, 2017

@kochigami @nlyubova IMO, this PR need unmerged PR (ros-simulation/gazebo_ros_pkgs#372), so better to wait for merge.

@kochigami
Copy link
Contributor Author

@nlyubova
I'm very sorry for my late response. As @k-okada says, I think we have to wait.
To be honest, I'm not sure why this pull-request works, so I'm going to learn ros-simulation/gazebo_ros_pkgs#372 for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants